interface objects should be Function objects as per Web IDL: - http://heycam.github.io/webidl/#interface-object - http://heycam.github.io/webidl/#es-interfaces So window.Event should be a Function object for e.g. but in WebKit it is a regular EventConstructor JSObject. Firefox and Chrome match the specification.
<rdar://problem/24569358>
<rdar://problem/24569376>
This should also impact the "constructor" properties on prototype objects (e.g. Event.prototype.constructor) as their value in a reference to the interface object: - http://heycam.github.io/webidl/#interface-prototype-object
Created attachment 270976 [details] WIP Patch
Attachment 270976 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMConstructor.h:37: The parameter name "globalObject" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSDOMConstructor.h:69: The parameter name "globalObject" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/bindings/js/JSDOMConstructor.h:92: The parameter name "globalObject" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 55 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 270976 [details] WIP Patch Attachment 270976 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/807987 Number of test failures exceeded the failure limit.
Created attachment 270978 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 270976 [details] WIP Patch Attachment 270976 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/807994 Number of test failures exceeded the failure limit.
Created attachment 270979 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 270976 [details] WIP Patch Attachment 270976 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/807992 Number of test failures exceeded the failure limit.
Created attachment 270980 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 270976 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270976&action=review > Source/WebCore/bindings/js/JSDOMConstructor.h:37 > + static JSC::JSValue prototypeForStructure(JSC::VM&, const JSDOMGlobalObject& globalObject); The style checker is correct that there’s no need for the argument name “global object” here. > Source/WebCore/bindings/js/JSDOMConstructor.h:69 > + static JSC::JSValue prototypeForStructure(JSC::VM&, const JSDOMGlobalObject& globalObject); Ditto. > Source/WebCore/bindings/js/JSDOMConstructor.h:115 > + static JSC::JSValue prototypeForStructure(JSC::VM&, const JSDOMGlobalObject&); Ditto.
(In reply to comment #12) > Comment on attachment 270976 [details] > WIP Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270976&action=review > > > Source/WebCore/bindings/js/JSDOMConstructor.h:37 > > + static JSC::JSValue prototypeForStructure(JSC::VM&, const JSDOMGlobalObject& globalObject); > > The style checker is correct that there’s no need for the argument name > “global object” here. > > > Source/WebCore/bindings/js/JSDOMConstructor.h:69 > > + static JSC::JSValue prototypeForStructure(JSC::VM&, const JSDOMGlobalObject& globalObject); > > Ditto. > > > Source/WebCore/bindings/js/JSDOMConstructor.h:115 > > + static JSC::JSValue prototypeForStructure(JSC::VM&, const JSDOMGlobalObject&); > > Ditto. Yes yes, this was just a "Work In Progress" patch that I will polish because marking as r?
No problem. Sometimes I review those by accident, sometimes intentionally. And sometimes people review mine. Sorry to waste your time replying to say something you were already planning to do!
Created attachment 271003 [details] WIP patch
Comment on attachment 271003 [details] WIP patch Attachment 271003 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/810257 New failing tests: js/dom/global-constructors-attributes.html
Created attachment 271009 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 271003 [details] WIP patch Attachment 271003 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/810231 New failing tests: http/tests/security/cross-frame-access-put.html js/dom/global-constructors-attributes.html
Created attachment 271010 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 271003 [details] WIP patch Attachment 271003 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/810283 New failing tests: http/tests/security/cross-frame-access-put.html js/dom/global-constructors-attributes.html
Created attachment 271011 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 271013 [details] Patch
Created attachment 271015 [details] Patch
Created attachment 271017 [details] Patch
Comment on attachment 271017 [details] Patch r=me
Comment on attachment 271017 [details] Patch Clearing flags on attachment: 271017 Committed r196392: <http://trac.webkit.org/changeset/196392>
All reviewed patches have been landed. Closing bug.
*** Bug 155293 has been marked as a duplicate of this bug. ***
*** Bug 74193 has been marked as a duplicate of this bug. ***