Bug 154374 - Reduce tiling coverage immediately when memory pressure hits.
Summary: Reduce tiling coverage immediately when memory pressure hits.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2016-02-17 18:41 PST by Andreas Kling
Modified: 2016-02-18 03:13 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.17 KB, patch)
2016-02-17 18:53 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (5.10 KB, patch)
2016-02-17 19:01 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-02-17 18:41:05 PST
We already reduce tiling coverage to a minimum (only the tiles that intersect the visible rect) during memory pressure.
However, this doesn't take effect immediately when we come under pressure, but the next time we flush our compositing state.
We should make sure to do it ASAP to avoid some pointless deaths.
Comment 1 Andreas Kling 2016-02-17 18:53:09 PST
Created attachment 271613 [details]
Patch
Comment 2 WebKit Commit Bot 2016-02-17 18:54:21 PST
Attachment 271613 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/MemoryPressureHandler.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2016-02-17 19:01:46 PST
Created attachment 271614 [details]
Patch
Comment 4 WebKit Commit Bot 2016-02-18 03:13:00 PST
Comment on attachment 271614 [details]
Patch

Clearing flags on attachment: 271614

Committed r196753: <http://trac.webkit.org/changeset/196753>
Comment 5 WebKit Commit Bot 2016-02-18 03:13:04 PST
All reviewed patches have been landed.  Closing bug.