Bug 154415 - Fake memory pressure handler should log detailed memory breakdown.
Summary: Fake memory pressure handler should log detailed memory breakdown.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-18 13:58 PST by Andreas Kling
Modified: 2016-02-23 13:31 PST (History)
2 users (show)

See Also:


Attachments
Patch (6.10 KB, patch)
2016-02-18 14:05 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-02-18 13:58:02 PST
Add detailed per-tag breakdown of dirty VM changes resulting from running the fake memory pressure handler.
Comment 1 Andreas Kling 2016-02-18 14:04:59 PST
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>: Per-tag breakdown of memory reclaimed by pressure handler:
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   ##           VM Tag     Before      After Difference
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   00            Tag 0    2715648    2715648          0
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   01           malloc     102400     102400          0
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   02   malloc (small)    1347584    1265664     -81920
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   03   malloc (large)    1863680    1687552    -176128
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   07    malloc (tiny)    1740800    1740800          0
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   15            IOKit   40497152   39297024   -1200128
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   1E            Stack     425984     425984          0
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   21            dylib      81920      81920          0
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   23  pmap (unshared)    1118208    1118208          0
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   2B     CoreServices       8192       8192          0
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   33    CoreAnimation      16384      16384          0
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   35          bmalloc   28114944   19619840   -8495104
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   40          JSC JIT     401408     131072    -270336
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   46          ImageIO    7065600      49152   -7016448
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   49    os_alloc_once       8192       8192          0
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   4A      libdispatch      24576      24576          0
Feb 18 23:03:10 box com.apple.WebKit.WebContent[1522] <Notice>:   4E           Tag 78      20480      20480          0
Comment 2 Andreas Kling 2016-02-18 14:05:40 PST
Created attachment 271691 [details]
Patch
Comment 3 WebKit Commit Bot 2016-02-18 14:06:44 PST
Attachment 271691 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2016-02-18 15:35:41 PST
Comment on attachment 271691 [details]
Patch

Clearing flags on attachment: 271691

Committed r196780: <http://trac.webkit.org/changeset/196780>
Comment 5 WebKit Commit Bot 2016-02-18 15:35:45 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2016-02-23 13:31:23 PST
Comment on attachment 271691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271691&action=review

> Source/WebCore/page/ResourceUsageThread.h:78
> +    TagInfo() { }

Why include this line of code? I think it’s a no op.