Bug 154693 - Don't clear the weak JSString cache on memory pressure.
Summary: Don't clear the weak JSString cache on memory pressure.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2016-02-25 14:31 PST by Andreas Kling
Modified: 2016-02-25 15:24 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.32 KB, patch)
2016-02-25 14:31 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-02-25 14:31:09 PST
The VM::stringCache is a weak JSString cache, clearing it does us no real good and breaks deduplication.
Comment 1 Andreas Kling 2016-02-25 14:31:48 PST
Created attachment 272241 [details]
Patch
Comment 2 WebKit Commit Bot 2016-02-25 15:24:36 PST
Comment on attachment 272241 [details]
Patch

Clearing flags on attachment: 272241

Committed r197141: <http://trac.webkit.org/changeset/197141>
Comment 3 WebKit Commit Bot 2016-02-25 15:24:40 PST
All reviewed patches have been landed.  Closing bug.