The SET_VAR macro doesn't handle nested substructures well, and there are a bunch of call sites that call DataRef::access() on a container substructure, possibly causing it to detach even though the leaf value is not actually changing.
Created attachment 273167 [details] Patch
Attachment 273167 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/RenderStyle.h:1503: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/rendering/style/RenderStyle.h:1504: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.h:1505: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 273167 [details] Patch nice, r=me
Comment on attachment 273167 [details] Patch Clearing flags on attachment: 273167 Committed r197680: <http://trac.webkit.org/changeset/197680>
All reviewed patches have been landed. Closing bug.