Bug 156166 - [WebGL2] Allow enabling WebGL2 with a runtime flag
Summary: [WebGL2] Allow enabling WebGL2 with a runtime flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 156061
  Show dependency tree / graph
 
Reported: 2016-04-04 07:09 PDT by Antoine Quint
Modified: 2016-04-05 04:22 PDT (History)
7 users (show)

See Also:

Attachments
Patch (16.59 KB, patch)
2016-04-05 02:16 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (16.50 KB, patch)
2016-04-05 03:21 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-04-04 07:09:56 PDT 
Alexey suggested in https://bugs.webkit.org/show_bug.cgi?id=156061 that we should be using a runtime flag for WebGL2 work. This task covers specifically the addition of a runtime flag.
Comment 1 Radar WebKit Bug Importer 2016-04-04 07:10:26 PDT 
<rdar://problem/25526929>
Comment 2 Antoine Quint 2016-04-05 02:16:40 PDT 
Created attachment 275651 [details]
Patch
Comment 3 WebKit Commit Bot 2016-04-05 02:18:59 PDT 
Attachment 275651 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:11:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dean Jackson 2016-04-05 02:39:49 PDT 
Comment on attachment 275651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275651&action=review

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:206
> +#if ENABLE(ENABLE_WEBGL2)

This should be ENABLE(WEBGL2). There are a few of these in the patch.
Comment 5 Antoine Quint 2016-04-05 03:21:52 PDT 
Created attachment 275655 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2016-04-05 04:22:21 PDT 
Comment on attachment 275655 [details]
Patch for landing

Clearing flags on attachment: 275655

Committed r199055: <http://trac.webkit.org/changeset/199055>
Comment 7 WebKit Commit Bot 2016-04-05 04:22:27 PDT 
All reviewed patches have been landed.  Closing bug.