Bug 157527 - bmalloc should automatically disable itself when ThreadSanitizer is used
Summary: bmalloc should automatically disable itself when ThreadSanitizer is used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-10 10:51 PDT by David Kilzer (:ddkilzer)
Modified: 2016-05-10 16:46 PDT (History)
6 users (show)

See Also:

Attachments
Patch v1 (2.69 KB, patch)
2016-05-10 11:14 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (2.69 KB, patch)
2016-05-10 14:13 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-05-10 10:51:51 PDT 
When ThreadSanitizer is loaded at runtime, bmalloc should disable itself, much like it does for AddressSanitizer.

This prevents false positive reports like the one in Bug 157462.
Comment 1 David Kilzer (:ddkilzer) 2016-05-10 11:14:42 PDT 
Created attachment 278515 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2016-05-10 14:13:04 PDT 
Created attachment 278529 [details]
Patch v2
Comment 3 David Kilzer (:ddkilzer) 2016-05-10 14:13:35 PDT 
Comment on attachment 278515 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=278515&action=review

> Source/bmalloc/bmalloc/Environment.cpp:121
> -    if (isASanEnabled())
> +    if (isSantizerEnabled())

Spelling is hard.
Comment 4 WebKit Commit Bot 2016-05-10 16:46:22 PDT 
Comment on attachment 278529 [details]
Patch v2

Clearing flags on attachment: 278529

Committed r200654: <http://trac.webkit.org/changeset/200654>
Comment 5 WebKit Commit Bot 2016-05-10 16:46:26 PDT 
All reviewed patches have been landed.  Closing bug.