Bug 158260 - Use inline capacity for StylePropertyShorthand Vectors.
Summary: Use inline capacity for StylePropertyShorthand Vectors.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2016-06-01 07:00 PDT by Andreas Kling
Modified: 2016-06-01 11:13 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.67 KB, patch)
2016-06-01 07:02 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff
Patch for landing (4.75 KB, patch)
2016-06-01 07:29 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-03 for mac-yosemite (914.92 KB, application/zip)
2016-06-01 09:02 PDT, WebKit Commit Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-06-01 07:00:31 PDT
0.5% of fastMalloc() bytes on PLUM are coming from Vector<StylePropertyShorthand>. We can avoid all of it by using inline capacity.
Comment 1 Andreas Kling 2016-06-01 07:02:58 PDT
Created attachment 280233 [details]
Patch
Comment 2 Antti Koivisto 2016-06-01 07:12:08 PDT
Comment on attachment 280233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280233&action=review

> Source/WebCore/css/StylePropertyShorthand.h:64
> +typedef Vector<StylePropertyShorthand, 4> StylePropertyShorthandVector;

I prefer 

using StylePropertyShorthandVector = Vector<StylePropertyShorthand, 4>;
Comment 3 Andreas Kling 2016-06-01 07:29:46 PDT
Created attachment 280234 [details]
Patch for landing

Ok then, Dr. Cargo Cultington!
Comment 4 WebKit Commit Bot 2016-06-01 09:02:15 PDT
Comment on attachment 280234 [details]
Patch for landing

Rejecting attachment 280234 [details] from commit-queue.

Number of test failures exceeded the failure limit.
Full output: http://webkit-queues.webkit.org/results/1418562
Comment 5 WebKit Commit Bot 2016-06-01 09:02:17 PDT
Created attachment 280239 [details]
Archive of layout-test-results from webkit-cq-03 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 WebKit Commit Bot 2016-06-01 11:13:06 PDT
Comment on attachment 280234 [details]
Patch for landing

Clearing flags on attachment: 280234

Committed r201559: <http://trac.webkit.org/changeset/201559>
Comment 7 WebKit Commit Bot 2016-06-01 11:13:10 PDT
All reviewed patches have been landed.  Closing bug.