Bug 158356 - Give RuleFeatures::classesMatchingAncestors some inline capacity.
Summary: Give RuleFeatures::classesMatchingAncestors some inline capacity.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2016-06-03 14:15 PDT by Andreas Kling
Modified: 2016-06-05 08:18 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2016-06-03 14:15 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-06-03 14:15:20 PDT 
There are about 362K Vector<AtomicStringImpl*> backing stores getting allocated and freed on a run of PLUM, in the RuleFeatures::classesMatchingAncestors vector.
Since RuleFeatures is only ever stack-allocated, we can avoid most/all of this by giving it some inline capacity.
Comment 1 Andreas Kling 2016-06-03 14:15:54 PDT 
Created attachment 280463 [details]
Patch
Comment 2 WebKit Commit Bot 2016-06-05 08:18:42 PDT 
Comment on attachment 280463 [details]
Patch

Clearing flags on attachment: 280463

Committed r201697: <http://trac.webkit.org/changeset/201697>
Comment 3 WebKit Commit Bot 2016-06-05 08:18:46 PDT 
All reviewed patches have been landed.  Closing bug.