Bug 158743 - REGRESSION (r202020): El Capitan CMake Debug build broken
Summary: REGRESSION (r202020): El Capitan CMake Debug build broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-14 10:59 PDT by David Kilzer (:ddkilzer)
Modified: 2016-06-14 15:10 PDT (History)
7 users (show)

See Also:

Attachments
Patch v1 (4.50 KB, patch)
2016-06-14 11:16 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-06-14 10:59:33 PDT 
This change caused the El Capitan CMake Debug build to break:

Bug 158716: False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm
<https://webkit.org/b/158716>
<https://trac.webkit.org/r202020>
Comment 1 David Kilzer (:ddkilzer) 2016-06-14 11:16:06 PDT 
Created attachment 281266 [details]
Patch v1
Comment 2 WebKit Commit Bot 2016-06-14 11:50:07 PDT 
Comment on attachment 281266 [details]
Patch v1

Clearing flags on attachment: 281266

Committed r202056: <http://trac.webkit.org/changeset/202056>
Comment 3 WebKit Commit Bot 2016-06-14 11:50:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 David Kilzer (:ddkilzer) 2016-06-14 12:45:13 PDT 
This is fixed (no longer hitting the error):

<https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/5881>

Here's the last build with the error for this bug:

<https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/5880>

In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/DumpRenderTreeCommon.cpp:2:
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/DumpRenderTree.h:38:
/Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/mac/DumpRenderTreeMac.h:55:44: error: expected function body after function declarator
WebView *createWebViewAndOffscreenWindow() NS_RETURNS_RETAINED;
                                           ^
1 error generated.
make[2]: *** [Tools/DumpRenderTree/CMakeFiles/DumpRenderTree.dir/DumpRenderTreeCommon.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/PixelDumpSupport.cpp:33:
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/DumpRenderTree.h:38:
/Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/mac/DumpRenderTreeMac.h:55:44: error: expected function body after function declarator
WebView *createWebViewAndOffscreenWindow() NS_RETURNS_RETAINED;
                                           ^
1 error generated.
Comment 5 David Kilzer (:ddkilzer) 2016-06-14 12:52:09 PDT 
Oops, DumpRenderTree is now missing the common DumpRenderTree_SOURCES from Tools/DumpRenderTree/CMakeLists.txt.

Going to attempt a build fix.
Comment 6 David Kilzer (:ddkilzer) 2016-06-14 13:16:30 PDT 
(In reply to comment #5)
> Oops, DumpRenderTree is now missing the common DumpRenderTree_SOURCES from
> Tools/DumpRenderTree/CMakeLists.txt.
> 
> Going to attempt a build fix.

And TestNetscapePlugin had the same issue.

Attempt a build fix:

Committed r202060: <http://trac.webkit.org/changeset/202060>
Comment 7 David Kilzer (:ddkilzer) 2016-06-14 15:09:22 PDT 
(In reply to comment #6)
> (In reply to comment #5)
> > Oops, DumpRenderTree is now missing the common DumpRenderTree_SOURCES from
> > Tools/DumpRenderTree/CMakeLists.txt.
> > 
> > Going to attempt a build fix.
> 
> And TestNetscapePlugin had the same issue.
> 
> Attempt a build fix:
> 
> Committed r202060: <http://trac.webkit.org/changeset/202060>

The build fix would have worked if not for a silly typo, fixed here:

Committed r202065: <http://trac.webkit.org/changeset/202065>