Bug 158825 - Move SoftLinking.h to platform/cococa from platform/mac
Summary: Move SoftLinking.h to platform/cococa from platform/mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-15 19:48 PDT by David Kilzer (:ddkilzer)
Modified: 2016-06-15 20:22 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (3.45 KB, patch)
2016-06-15 19:52 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-06-15 19:48:40 PDT 
Move SoftLinking.h to platform/cococa from platform/mac because it's used on both iOS and macOS.
Comment 1 David Kilzer (:ddkilzer) 2016-06-15 19:52:18 PDT 
Created attachment 281429 [details]
Patch v1
Comment 2 WebKit Commit Bot 2016-06-15 19:54:08 PDT 
Attachment 281429 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:28:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:110:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:128:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:133:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:434:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:447:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:452:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:464:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:475:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:480:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 11 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2016-06-15 20:22:07 PDT 
Comment on attachment 281429 [details]
Patch v1

Clearing flags on attachment: 281429

Committed r202122: <http://trac.webkit.org/changeset/202122>
Comment 4 WebKit Commit Bot 2016-06-15 20:22:10 PDT 
All reviewed patches have been landed.  Closing bug.