We could hasten the dropping of decoded image data when a CachedImage is really only used by page cached pages.
Created attachment 281649 [details] Patch thing
Created attachment 281650 [details] Patch thing
Comment on attachment 281650 [details] Patch thing Rejecting attachment 281650 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 281650, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ing rebase: :040000 040000 52ddce205a5ea636dcff0e63495fa587c341e608 f3f1d4fa1265a983a518943e7e3a0f794477e6bd M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/1536811
Comment on attachment 281650 [details] Patch thing Rejecting attachment 281650 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 281650, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ng: https://bugs.webkit.org/show_bug.cgi?id=158941&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 281650 from bug 158941. /Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource From git://git.webkit.org/WebKit + d894a6a...705033b master -> origin/master (forced update) Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/1537172
Comment on attachment 281650 [details] Patch thing Clearing flags on attachment: 281650 Committed r202231: <http://trac.webkit.org/changeset/202231>
All reviewed patches have been landed. Closing bug.
Note that it seems that the Mac PLT regressed around the time this patch landed. I am working on confirming the regression came from this change.
Reverted r202231 for reason: Seems to have regressed PLT on both iOS and Mac (very obvious on iOS Warm PLT) Committed r202278: <http://trac.webkit.org/changeset/202278>
(In reply to comment #8) > Reverted r202231 for reason: > > Seems to have regressed PLT on both iOS and Mac (very obvious on iOS Warm > PLT) > > Committed r202278: <http://trac.webkit.org/changeset/202278> Clear 1% progression on MacBookPro PLT from the roll out.
(In reply to comment #9) > (In reply to comment #8) > > Reverted r202231 for reason: > > > > Seems to have regressed PLT on both iOS and Mac (very obvious on iOS Warm > > PLT) > > > > Committed r202278: <http://trac.webkit.org/changeset/202278> > > Clear 1% progression on MacBookPro PLT from the roll out. Similar progression on iOS from the rollout.