We should implement https://heycam.github.io/webidl/#idl-setlike and apply to FontFaceSet.idl
Created attachment 282117 [details] Patch
Created attachment 282121 [details] Fixing style
As part of this bug, we should ensure that binding generator dies for "iterable" interfaces that do not have indexed getters.
Created attachment 300409 [details] WIP
*** Bug 159146 has been marked as a duplicate of this bug. ***
Created attachment 301878 [details] Patch
Attachment 301878 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMSetLike.h:66: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSDOMGuardedObject.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSDOMGlobalObject.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSDOMPromise.h:121: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 4 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Setlike part of the patch is working. Integration with FontFacetSet is not properly working since every time the backing font face set is updated, we should update the FontFacet set like object. Current iterator implementation enforces this by iterating through the backing font face set.
Comment on attachment 301878 [details] Patch Attachment 301878 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3141693 New failing tests: fast/text/font-face-set-cssom.html fast/text/font-face-set-javascript.html
Created attachment 301891 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 301878 [details] Patch Attachment 301878 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3141697 New failing tests: fast/text/font-face-set-cssom.html fast/text/font-face-set-javascript.html
Created attachment 301893 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 301878 [details] Patch Attachment 301878 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3141701 New failing tests: fast/text/font-face-set-cssom.html fast/text/font-face-set-javascript.html
Created attachment 301894 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 301878 [details] Patch Attachment 301878 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3141703 New failing tests: fast/text/font-face-set-cssom.html fast/text/font-face-set-javascript.html
Created attachment 301895 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 382820 [details] Reduced patch to binding code
Created attachment 383850 [details] Patch
Created attachment 383933 [details] Patch
Comment on attachment 383933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383933&action=review > Source/WebCore/bindings/scripts/IDLParser.pm:2108 > + # FIXME: Add support to forEach What's the status on this part?
(In reply to Darin Adler from comment #20) > Comment on attachment 383933 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383933&action=review > > > Source/WebCore/bindings/scripts/IDLParser.pm:2108 > > + # FIXME: Add support to forEach > > What's the status on this part? I'll add support as a follow-up
Comment on attachment 383933 [details] Patch Clearing flags on attachment: 383933 Committed r253100: <https://trac.webkit.org/changeset/253100>
All reviewed patches have been landed. Closing bug.
<rdar://problem/57620807>