Bug 163098 - [WK2] didRemoveFrameFromHierarchy callback doesn't fire for subframes when evicting from PageCache.
Summary: [WK2] didRemoveFrameFromHierarchy callback doesn't fire for subframes when ev...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-06 19:48 PDT by Andreas Kling
Modified: 2016-10-07 11:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch for EWS (16.97 KB, patch)
2016-10-06 22:25 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (17.93 KB, patch)
2016-10-07 09:33 PDT, Andreas Kling 		koivisto: review+
koivisto: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (17.93 KB, patch)
2016-10-07 11:34 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-10-06 19:48:32 PDT 
<rdar://problem/28663488>
Comment 1 Andreas Kling 2016-10-06 22:25:18 PDT 
Created attachment 290895 [details]
Patch for EWS

Needs a proper ChangeLog, but let's test this fix on the EWS.
Comment 2 WebKit Commit Bot 2016-10-06 22:26:24 PDT 
Attachment 290895 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:41:  The parameter name "bundle" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:41:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2016-10-07 09:33:17 PDT 
Created attachment 290933 [details]
Patch
Comment 4 Antti Koivisto 2016-10-07 09:40:45 PDT 
Comment on attachment 290933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290933&action=review

> Tools/TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp:91
> +    WKPageLoadURL(webView.page(), adoptWK(Util::createURLForResource("many-iframes", "html")).get());
> +    Util::run(&finished);
> +
> +    // Perform a couple of loads so "simple-iframe" gets kicked out of the PageCache.

There is no "simple-iframe" anywhere. I think you mean "many-iframes".
Comment 5 Antti Koivisto 2016-10-07 09:41:51 PDT 
Nice test though!
Comment 6 Andreas Kling 2016-10-07 11:34:21 PDT 
Created attachment 290949 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2016-10-07 11:57:40 PDT 
Comment on attachment 290949 [details]
Patch for landing

Clearing flags on attachment: 290949

Committed r206922: <http://trac.webkit.org/changeset/206922>
Comment 8 WebKit Commit Bot 2016-10-07 11:57:46 PDT 
All reviewed patches have been landed.  Closing bug.