Bug 164345 - MarkedSpace should have specialized size classes for popular engine objects.
Summary: MarkedSpace should have specialized size classes for popular engine objects.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2016-11-02 15:50 PDT by Andreas Kling
Modified: 2016-11-02 17:47 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.04 KB, patch)
2016-11-02 15:51 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (3.47 KB, patch)
2016-11-02 16:43 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-11-02 15:50:16 PDT 
The four chunkiest memory hogs in JSC are FunctionCodeBlock, FunctionExecutable, UnlinkedFunctionCodeBlock and UnlinkedFunctionExecutable.
Let's inject size classes for their exact sizes to improve space utilization.
Comment 1 Andreas Kling 2016-11-02 15:51:12 PDT 
Created attachment 293703 [details]
Patch
Comment 2 Filip Pizlo 2016-11-02 16:10:54 PDT 
Comment on attachment 293703 [details]
Patch

Shouldn't this have a sedum step to make sure that you didn't add the same size twice?
Comment 3 Andreas Kling 2016-11-02 16:23:48 PDT 
Comment on attachment 293703 [details]
Patch

Oh, yeah.
Comment 4 Andreas Kling 2016-11-02 16:43:14 PDT 
Created attachment 293715 [details]
Patch

Deduplicate the list of size classes.
Comment 5 Andreas Kling 2016-11-02 17:23:46 PDT 
Comment on attachment 293715 [details]
Patch

Thanks Filip!
Comment 6 WebKit Commit Bot 2016-11-02 17:47:39 PDT 
Comment on attachment 293715 [details]
Patch

Clearing flags on attachment: 293715

Committed r208317: <http://trac.webkit.org/changeset/208317>
Comment 7 WebKit Commit Bot 2016-11-02 17:47:44 PDT 
All reviewed patches have been landed.  Closing bug.