Bug 165901 - Always clear RenderLayer backing stores when going into page cache.
Summary: Always clear RenderLayer backing stores when going into page cache.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-15 08:52 PST by Andreas Kling
Modified: 2016-12-15 10:37 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.02 KB, patch)
2016-12-15 08:54 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-12-15 08:52:27 PST 
We currently have a setting that's always on for iOS and GTK+ that makes us drop RenderLayer backing stores when going into page cache.
Let's enable it on all ports to unify the behavior and free up a little memory.
Comment 1 Andreas Kling 2016-12-15 08:54:38 PST 
Created attachment 297194 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-12-15 09:55:06 PST 
Comment on attachment 297194 [details]
Patch

Have you tested to see if this causes any new flashing on Mac when going back/forward in history via the menu or swiping?
Comment 3 Andreas Kling 2016-12-15 10:00:21 PST 
(In reply to comment #2)
> Comment on attachment 297194 [details]
> Patch
> 
> Have you tested to see if this causes any new flashing on Mac when going
> back/forward in history via the menu or swiping?

I have! There's no new flash or flicker when going back/forward as far as I can see.
Comment 4 WebKit Commit Bot 2016-12-15 10:37:54 PST 
Comment on attachment 297194 [details]
Patch

Clearing flags on attachment: 297194

Committed r209865: <http://trac.webkit.org/changeset/209865>
Comment 5 WebKit Commit Bot 2016-12-15 10:37:59 PST 
All reviewed patches have been landed.  Closing bug.