Bug 166724 - REGRESSION(r210226): overflow:scroll position not restored on back navigation
Summary: REGRESSION(r210226): overflow:scroll position not restored on back navigation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2017-01-05 05:32 PST by Andreas Kling
Modified: 2017-06-16 17:26 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.74 KB, patch)
2017-01-05 06:56 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2017-01-05 05:32:48 PST 
RenderLayer isn't caching its scroll offset to the Element like it should.
Comment 1 Andreas Kling 2017-01-05 06:56:55 PST 
Created attachment 298099 [details]
Patch
Comment 2 Antti Koivisto 2017-01-05 07:04:05 PST 
Comment on attachment 298099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298099&action=review

> LayoutTests/fast/scrolling/page-cache-back-overflow-scroll-restore-expected.txt:10
> +layer at (0,0) size 100x126 backgroundClip at (0,0) size 100x100 clip at (0,0) size 85x85 scrollY 41 scrollHeight 126
> +  RenderBlock (positioned) {DIV} at (0,0) size 100x100 [bgcolor=#CCCCCC]

It would be nicer to have either reftest or api based test but ok.
Comment 3 WebKit Commit Bot 2017-01-05 08:03:42 PST 
Comment on attachment 298099 [details]
Patch

Clearing flags on attachment: 298099

Committed r210329: <http://trac.webkit.org/changeset/210329>
Comment 4 WebKit Commit Bot 2017-01-05 08:03:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-06-16 17:26:42 PDT 
<rdar://problem/32827176>