Bug 168061 - Document::settings() should return a const Settings&.
Summary: Document::settings() should return a const Settings&.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-09 11:28 PST by Andreas Kling
Modified: 2017-02-09 12:34 PST (History)
1 user (show)

See Also:

Attachments
Patch (11.61 KB, patch)
2017-02-09 11:33 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2017-02-09 11:28:21 PST 
Antti suggested having Document::settings() return a const Settings&, and also having a Settings& mutableSettings() if needed.
I think this would be a nice pattern, so let's implement it.
Comment 1 Andreas Kling 2017-02-09 11:33:59 PST 
Created attachment 301061 [details]
Patch
Comment 2 Geoffrey Garen 2017-02-09 11:37:10 PST 
Comment on attachment 301061 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2017-02-09 12:34:01 PST 
Comment on attachment 301061 [details]
Patch

Clearing flags on attachment: 301061

Committed r211979: <http://trac.webkit.org/changeset/211979>
Comment 4 WebKit Commit Bot 2017-02-09 12:34:04 PST 
All reviewed patches have been landed.  Closing bug.