Bug 168653 - [iOS] WebKit1 should use shared memory pressure handler code.
Summary: [iOS] WebKit1 should use shared memory pressure handler code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-21 06:45 PST by Andreas Kling
Modified: 2017-02-21 13:06 PST (History)
1 user (show)

See Also:

Attachments
Patch (15.76 KB, patch)
2017-02-21 07:02 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (17.31 KB, patch)
2017-02-21 07:06 PST, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
Patch for landing (16.90 KB, patch)
2017-02-21 08:10 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2017-02-21 06:45:49 PST 
WebKit1 on iOS currently has its own little memory pressure handler implementation. Let's share the code with the other ports.
Comment 1 Andreas Kling 2017-02-21 07:02:00 PST 
Created attachment 302254 [details]
Patch
Comment 2 WebKit Commit Bot 2017-02-21 07:04:38 PST 
Attachment 302254 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebView.mm:9876:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2017-02-21 07:06:09 PST 
Created attachment 302255 [details]
Patch
Comment 4 WebKit Commit Bot 2017-02-21 07:07:26 PST 
Attachment 302255 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebView.mm:9842:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Antti Koivisto 2017-02-21 07:24:38 PST 
Comment on attachment 302255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302255&action=review

> Source/WebKit/mac/WebView/WebViewPrivate.h:-459
> -+ (BOOL)_isUnderMemoryPressure;
> -+ (void)_clearMemoryPressure;
> -+ (BOOL)_shouldWaitForMemoryClearMessage;
> -+ (void)_releaseMemoryNow;

Please make sure there are no clients for these.
Comment 6 Andreas Kling 2017-02-21 08:10:35 PST 
Created attachment 302259 [details]
Patch for landing

Keep _releaseMemoryNow as it turns out there are Apple-internal clients for that. Thx2Antti for being suspicious about this!
Comment 7 WebKit Commit Bot 2017-02-21 08:11:28 PST 
Attachment 302259 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebView.mm:1678:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Source/WebKit/mac/WebView/WebView.mm:9849:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2017-02-21 13:06:36 PST 
Comment on attachment 302259 [details]
Patch for landing

Clearing flags on attachment: 302259

Committed r212742: <http://trac.webkit.org/changeset/212742>
Comment 9 WebKit Commit Bot 2017-02-21 13:06:41 PST 
All reviewed patches have been landed.  Closing bug.