<rdar://problem/31245009> On iOS we already detach backing stores for compositing layers outside of the tiling coverage rect. Let's bring this feature Back to the Mac(tm)!
Created attachment 305333 [details] Proposed patch
Attachment 305333 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:282: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 305335 [details] Proposed patch
Attachment 305335 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:282: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 305335 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=305335&action=review > LayoutTests/ChangeLog:4 > + <https://webkit.org/b/170082> This isn't the format that webkit-patch uses.
Comment on attachment 305335 [details] Proposed patch Attachment 305335 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3406479 New failing tests: fast/text-autosizing/text-size-adjust-inline-style.html fast/hidpi/filters-and-image-buffer-resolution.html
Created attachment 305345 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 305335 [details] Proposed patch Attachment 305335 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3406508 New failing tests: compositing/backing-store-attachment-1.html
Created attachment 305351 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 311790 [details] Proposed patch - Fix the layout test failures by simply never detaching backing stores for scroll control layers. - Add iOS baseline for the new test.
Attachment 311790 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:297: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 311790 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=311790&action=review > Source/WebCore/platform/graphics/GraphicsLayer.h:552 > + bool mayDetachBackingStore() const { return m_mayDetachBackingStore; } canDetach? setNeverDetach?
Created attachment 311797 [details] Patch for landing Sure, let's go with canDetach.
Comment on attachment 311797 [details] Patch for landing Rejecting attachment 311797 [details] from commit-queue. New failing tests: compositing/backing-store-attachment-1.html Full output: http://webkit-queues.webkit.org/results/3857545
Created attachment 311799 [details] Archive of layout-test-results from webkit-cq-01 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 311800 [details] Patch for landing Oops, I messed up a bool condition while playing with "canDetach" vs "neverDetach" :| thx2cq for catching it.
Attachment 311800 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:297: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 311800 [details] Patch for landing Clearing flags on attachment: 311800 Committed r217696: <http://trac.webkit.org/changeset/217696>
All reviewed patches have been landed. Closing bug.