Bug 171122 - Switch from -std=gnu++11 to -std=gnu++14 for consistency in DerivedSources.make
Summary: Switch from -std=gnu++11 to -std=gnu++14 for consistency in DerivedSources.make
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-21 11:05 PDT by David Kilzer (:ddkilzer)
Modified: 2017-04-21 13:02 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.85 KB, patch)
2017-04-21 11:07 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-04-21 11:05:25 PDT
DerivedSources.make in WebCore and WebKit2 still specify -std=gnu++11 instead of -std=gnu++14.

These commands are only run for "ifeq ($(OS),MACOS)", so it won't affect Windows or other ports.
Comment 1 David Kilzer (:ddkilzer) 2017-04-21 11:07:09 PDT
Created attachment 307753 [details]
Patch
Comment 2 Brent Fulgham 2017-04-21 11:11:46 PDT
Comment on attachment 307753 [details]
Patch

LGTM.
Comment 3 Brent Fulgham 2017-04-21 12:33:30 PDT
Comment on attachment 307753 [details]
Patch

Tests pass, so cq+
Comment 4 WebKit Commit Bot 2017-04-21 13:02:07 PDT
Comment on attachment 307753 [details]
Patch

Clearing flags on attachment: 307753

Committed r215629: <http://trac.webkit.org/changeset/215629>
Comment 5 WebKit Commit Bot 2017-04-21 13:02:08 PDT
All reviewed patches have been landed.  Closing bug.