Bug 172189 - Remove C-style casts by using xmlDocPtr instead of void*
Summary: Remove C-style casts by using xmlDocPtr instead of void*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-16 14:31 PDT by David Kilzer (:ddkilzer)
Modified: 2017-05-16 22:05 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.15 KB, patch)
2017-05-16 14:31 PDT, David Kilzer (:ddkilzer)
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-05-16 14:31:26 PDT
Need the bug URL (OOPS!).

Reviewed by NOBODY (OOPS!).

* dom/TransformSource.h:
(typedef PlatformTransformSource): Use xmlDocPtr not void*.
* dom/TransformSourceLibxslt.cpp:
(WebCore::TransformSource::~TransformSource): Remove cast.
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::document): Remove cast.
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::xmlDocPtrFromNode): Remove casts.
* xml/parser/XMLDocumentParser.h:
(WebCore::xmlDocPtrForString): Update declaration to return
xmlDocPtr not void*.
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doEnd): Change type of local
variable from void* to xmlDocPtr.
(WebCore::xmlDocPtrForString): Update to return xmlDocPtr
not void*.
---
 7 files changed, 33 insertions(+), 8 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2017-05-16 14:31:27 PDT
Created attachment 310297 [details]
Patch
Comment 2 Build Bot 2017-05-16 14:32:42 PDT
Attachment 310297 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/TransformSource.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Kilzer (:ddkilzer) 2017-05-16 14:44:43 PDT
(In reply to Build Bot from comment #2)
> Attachment 310297 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/dom/TransformSource.h:32:  Code inside a namespace
> should not be indented.  [whitespace/indent] [4]
> Total errors found: 1 in 7 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

I can clean this up, too, before landing.
Comment 4 David Kilzer (:ddkilzer) 2017-05-16 22:05:03 PDT
Committed r216968: <http://trac.webkit.org/changeset/216968>