Bug 172190 - WebCore::leakCGColor() needs CF_RETURNS_RETAINED annotation
Summary: WebCore::leakCGColor() needs CF_RETURNS_RETAINED annotation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-16 14:36 PDT by David Kilzer (:ddkilzer)
Modified: 2017-05-16 15:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2017-05-16 14:36 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-05-16 14:36:14 PDT 
Need the bug URL (OOPS!).

Reviewed by NOBODY (OOPS!).

* platform/graphics/cg/ColorCG.cpp:
(WebCore::leakCGColor): Annotate with CF_RETURNS_RETAINED since
it does not follow the CF naming convention, which means the
expected behavior can't be inferred by the clang static
analyzer.
---
 2 files changed, 14 insertions(+), 1 deletion(-)
Comment 1 David Kilzer (:ddkilzer) 2017-05-16 14:36:15 PDT 
Created attachment 310299 [details]
Patch
Comment 2 WebKit Commit Bot 2017-05-16 15:20:11 PDT 
Comment on attachment 310299 [details]
Patch

Clearing flags on attachment: 310299

Committed r216949: <http://trac.webkit.org/changeset/216949>
Comment 3 WebKit Commit Bot 2017-05-16 15:20:13 PDT 
All reviewed patches have been landed.  Closing bug.