Bug 172381 - Web Inspector: Use initialLayout for DetailsSidebarPanel classes
Summary: Web Inspector: Use initialLayout for DetailsSidebarPanel classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks: 172303
  Show dependency tree / graph
 
Reported: 2017-05-19 13:23 PDT by Devin Rousso
Modified: 2017-06-09 15:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (66.46 KB, patch)
2017-05-19 13:40 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] Timeline Before (484.82 KB, image/png)
2017-05-19 13:40 PDT, Devin Rousso 		no flags Details
[Image] Timeline After (451.93 KB, image/png)
2017-05-19 13:40 PDT, Devin Rousso 		no flags Details
Patch (26.52 KB, patch)
2017-05-19 15:43 PDT, Devin Rousso 		timothy: review+
Details | Formatted Diff | Diff
Patch (27.02 KB, patch)
2017-06-02 19:59 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-05-19 13:23:24 PDT 
In addition, all of these classes are constructed during load on the WebInspector object.  Each DetailsSidebarPanel should only be created once a tab that requires it is shown.
Comment 1 Devin Rousso 2017-05-19 13:40:33 PDT 
Created attachment 310692 [details]
Patch
Comment 2 Devin Rousso 2017-05-19 13:40:47 PDT 
Created attachment 310693 [details]
[Image] Timeline Before
Comment 3 Devin Rousso 2017-05-19 13:40:59 PDT 
Created attachment 310694 [details]
[Image] Timeline After
Comment 4 Matt Baker 2017-05-19 13:45:08 PDT 
Comment on attachment 310692 [details]
Patch

This is going to be a pretty big change. I think we should remove global instantiation of panels as a stand alone patch. It is unrelated to the initialLayout/layout issue.
Comment 5 Devin Rousso 2017-05-19 15:43:29 PDT 
Created attachment 310715 [details]
Patch
Comment 6 Timothy Hatcher 2017-06-02 10:14:58 PDT 
Comment on attachment 310715 [details]
Patch

Looks good. Please test this well.
Comment 7 Devin Rousso 2017-06-02 19:59:11 PDT 
Created attachment 311900 [details]
Patch
Comment 8 WebKit Commit Bot 2017-06-02 20:37:57 PDT 
Comment on attachment 311900 [details]
Patch

Clearing flags on attachment: 311900

Committed r217749: <http://trac.webkit.org/changeset/217749>
Comment 9 WebKit Commit Bot 2017-06-02 20:37:59 PDT 
All reviewed patches have been landed.  Closing bug.