Bug 172804 - TestNetscapePlugIn: Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
Summary: TestNetscapePlugIn: Move WTF_ATTRIBUTE_PRINTF() from implementation to declar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-01 05:00 PDT by David Kilzer (:ddkilzer)
Modified: 2017-06-06 11:45 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.05 KB, patch)
2017-06-01 05:00 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (4.85 KB, patch)
2017-06-01 05:11 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v3 (5.87 KB, patch)
2017-06-01 10:08 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-06-01 05:00:49 PDT 
Need the bug URL (OOPS!).

Reviewed by NOBODY (OOPS!).

WTF_ATTRIBUTE_PRINTF() only works outside the current
compilation unit if it's on the declaration, not the
implementation, of a function or class method.

* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
---
 5 files changed, 19 insertions(+), 6 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2017-06-01 05:00:50 PDT 
Created attachment 311690 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2017-06-01 05:02:28 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #1)
> Created attachment 311690 [details]
> Patch

This may need the following fix as well:

+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wformat-nonliteral"
     pluginLogWithArguments(instance, format, args);
+#pragma clang diagnostic pop

Waiting for EWS.
Comment 3 David Kilzer (:ddkilzer) 2017-06-01 05:11:25 PDT 
Created attachment 311691 [details]
Patch v2
Comment 4 David Kilzer (:ddkilzer) 2017-06-01 10:08:14 PDT 
Created attachment 311714 [details]
Patch v3
Comment 5 WebKit Commit Bot 2017-06-06 11:45:28 PDT 
Comment on attachment 311714 [details]
Patch v3

Clearing flags on attachment: 311714

Committed r217847: <http://trac.webkit.org/changeset/217847>
Comment 6 WebKit Commit Bot 2017-06-06 11:45:29 PDT 
All reviewed patches have been landed.  Closing bug.