Bug 173836 - [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
Summary: [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchem...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on: 173730
Blocks:
  Show dependency tree / graph
 
Reported: 2017-06-26 09:38 PDT by David Kilzer (:ddkilzer)
Modified: 2017-06-27 17:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch v1 (2.86 KB, patch)
2017-06-26 09:40 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-06-26 09:38:47 PDT 
Commit r218750 introduced a leak of an NSURLResponse object in WKURLSchemeHandler-1.mm.

Bug 173730: Add SPI to WKURLSchemeTask for redirection
<​https://bugs.webkit.org/show_bug.cgi?id=173730>
<https://trac.webkit.org/r218750>
Comment 1 David Kilzer (:ddkilzer) 2017-06-26 09:40:47 PDT 
Created attachment 313845 [details]
Patch v1
Comment 2 Brady Eidson 2017-06-26 10:19:22 PDT 
Comment on attachment 313845 [details]
Patch v1

Alex--!!! (And whoever reviewed that!)
Comment 3 WebKit Commit Bot 2017-06-26 10:48:39 PDT 
Comment on attachment 313845 [details]
Patch v1

Clearing flags on attachment: 313845

Committed r218810: <http://trac.webkit.org/changeset/218810>
Comment 4 WebKit Commit Bot 2017-06-26 10:48:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2017-06-27 17:28:28 PDT 
Maybe some day we can use ARC for our tests even before we move to using ARC to compile WebKit itself.