Bug 175056 - Upgrade Buildbot instance on build.webkit.org to latest Buildbot
Summary: Upgrade Buildbot instance on build.webkit.org to latest Buildbot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on: 217127 217394 217431 217434 217672 217702 217727 217823 217830 217831 217834 217836 217914 217958 218102 218130 218230 218234 218302 218439 218582 218629 218656 218706 218711 218755 218759 218802 218805 218817 218818 218819 218821 218822 218904 218907 218922 219082 219083 219084 219085 219133 219356 219363 219364 219374 219454 220513 220544 220589 220864 220932 221052 221090 221208 221263 221280 221493 221536 221558
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-01 15:52 PDT by Aakash Jain
Modified: 2021-03-10 06:22 PST (History)
14 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-08-01 15:52:10 PDT
We are running Buildbot version 0.8.6p1 on build.webkit.org (https://build.webkit.org/about). This is more than 5 years old version.

Buildbot 0.9 was released last year and has a lot of new features, including brand-new UI (See https://nine.buildbot.net).

We should upgrade the buildbot instance to the latest version.
Comment 1 Carlos Alberto Lopez Perez 2017-08-02 15:00:30 PDT
I find the waterfall view on 0.9 to be really less useful than the one from 0.8 because it will not longer be possible to see the details of what step failed without hovering the mouse over each red rectangle.

Check for example: http://buildbot.scons.org/#/waterfall (you need to move the mouse over each red build to see what went wrong). Compare that with our current waterfall https://build.webkit.org/waterfall where the details of what exactly failed are wrote directly as text on the red rectangles, so you can see exactly what went wrong much easier.

This is a known limitation of 0.9 as documented here http://docs.buildbot.net/current/manual/cfg-www.html
Comment 2 Aakash Jain 2017-08-04 14:07:32 PDT
Also see: <rdar://problem/26245354>
Comment 3 Simon Fraser (smfr) 2017-12-11 13:43:30 PST
Agreed, the new waterfall is horrible.
Comment 4 Fujii Hironori 2018-11-30 00:12:13 PST
[webkit-dev] Buildbot upgrade on build.webkit.org
https://lists.webkit.org/pipermail/webkit-dev/2017-December/029804.html

Waterfall view should display steps information without hovering over · Issue #3884 · buildbot/buildbot
https://github.com/buildbot/buildbot/issues/3884
Comment 5 Don Olmstead 2019-03-04 11:14:56 PST
Is there any status for this? We'd like to test out a buildbot for playstation locally before turning it on in trunk. Would be great to just target the latest buildbot. The latest release at this time is 2.0.1, http://docs.buildbot.net/current/relnotes/index.html .
Comment 6 Aakash Jain 2019-03-11 09:30:47 PDT
(In reply to Don Olmstead from comment #5)
> Is there any status for this? 
Haven't started work on this. One of the main blocker is the concern people have about waterfall/console view of new Buildbot.
Comment 7 Michael Catanzaro 2019-03-12 09:05:35 PDT
FWIW I think waterfall view is not very important, because we have https://build.webkit.org/dashboard/, which is an elaborate workaround to avoid the need to ever look at the waterfall. Is this dashboard good enough for people used to looking at the waterfall?

For GTK/WPE, all our bots should be on the dashboard.
Comment 8 Ryosuke Niwa 2019-07-09 10:42:20 PDT
(In reply to Michael Catanzaro from comment #7)
> FWIW I think waterfall view is not very important, because we have
> https://build.webkit.org/dashboard/, which is an elaborate workaround to
> avoid the need to ever look at the waterfall. Is this dashboard good enough
> for people used to looking at the waterfall?

I never use the dashboard because I can never reason what's happening.
Comment 9 Don Olmstead 2019-07-09 12:40:16 PDT
(In reply to Ryosuke Niwa from comment #8)
> (In reply to Michael Catanzaro from comment #7)
> > FWIW I think waterfall view is not very important, because we have
> > https://build.webkit.org/dashboard/, which is an elaborate workaround to
> > avoid the need to ever look at the waterfall. Is this dashboard good enough
> > for people used to looking at the waterfall?
> 
> I never use the dashboard because I can never reason what's happening.

For Sony we're fine with just having the dashboard and plan on adding our bots to it after landing. Having a single buildbot version to target for per commit builds as well as EWS would reduce the burden for running infrastructure for us.

Its my understanding that we can customize our own dashboards using buildbot so is there something we could expand on the dashboard that would make the waterfall users happy? We can always expand the dashboard over time with additional functionality. I'm not sure realistically how long we can keep up with an old buildbot especially with the maintenance burden and potential security risks.
Comment 10 Aakash Jain 2020-09-30 08:35:56 PDT
I am going to start working on this Buildbot upgrade soon.

As we are running an ancient version of Buildbot on build.webkit.org:
- we risk Security
- maintenance cost is higher (e.g.: many scripts (like dashboard) needs to talk to both old and new Buildbot API, we can't easily share code between build.webkit.org and ews-build.webkit.org)
- users don't have a consistent experience on build.webkit.org and EWS buildbot (ews-build.webkit.org)

Many users are eagerly waiting for build.webkit.org upgrade. There might still be concerns about waterfall view (and I do agree with waterfall view being not so useful in newer Buildbot). At the same time, we need to move forward, we can't stick to ancient version of Buildbot forever. I talked to some of the people who had concerns previously, and they don't object to upgrade anymore. Also, Bot watchers in Apple (whom I would have expected the most frequent users of waterfall/console views) don't actually use waterfall/console views, they use the dashboard instead.
Comment 11 Aakash Jain 2020-09-30 08:36:41 PDT
Also, the plan is to upgrade to latest Buildbot, and make the Buildbot configuration Python 3 compatible.
Comment 12 Aakash Jain 2021-02-08 13:21:43 PST
We have upgraded build.webkit.org to new Buildbot (v2.10.0, released on 2021-01-02).
Comment 13 Aakash Jain 2021-02-08 16:34:09 PST
We have now upgraded build.webkit.org to latest Buildbot (v2.10.1, released on 2021-01-29).
Comment 14 Aakash Jain 2021-02-08 16:36:10 PST
This is a brand new server. Buildbot doesn't support migrating data from old version. 

Old instance is accessible at https://build-old.webkit.org
Comment 15 Aakash Jain 2021-03-10 06:22:08 PST
I just upgraded build.webkit.org to Buildbot v2.10.2 (released on 2021-03-07).