[Canvas] Split CanvasRenderingContext2D.idl into seperate IDLs to match current HTML spec
Created attachment 319742 [details] Patch
Comment on attachment 319742 [details] Patch Attachment 319742 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4437127 New failing tests: fast/canvas/canvas-stroke-path.html js/dom/global-constructors-attributes-dedicated-worker.html inspector/canvas/recording-2d.html fast/canvas/canvas-path-isPointInStroke.html fast/canvas/winding-enumeration.html fast/canvas/canvas-fill-path.html fast/canvas/canvas-path-addPath.html fast/canvas/canvas-clip-path.html fast/canvas/canvas-path-isPointInPath.html
Created attachment 319744 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 319742 [details] Patch Attachment 319742 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4437138 New failing tests: fast/canvas/canvas-stroke-path.html js/dom/global-constructors-attributes-dedicated-worker.html inspector/canvas/recording-2d.html fast/canvas/canvas-path-isPointInStroke.html fast/canvas/winding-enumeration.html fast/canvas/canvas-fill-path.html fast/canvas/canvas-path-addPath.html fast/canvas/canvas-clip-path.html fast/canvas/canvas-path-isPointInPath.html
Created attachment 319745 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 319742 [details] Patch Attachment 319742 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4437160 New failing tests: fast/canvas/canvas-stroke-path.html js/dom/global-constructors-attributes-dedicated-worker.html inspector/canvas/recording-2d.html fast/canvas/canvas-path-isPointInStroke.html fast/canvas/winding-enumeration.html fast/canvas/canvas-fill-path.html fast/canvas/canvas-path-addPath.html fast/canvas/canvas-clip-path.html fast/canvas/canvas-path-isPointInPath.html
Created attachment 319747 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 319742 [details] Patch Attachment 319742 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4437168 New failing tests: fast/canvas/canvas-stroke-path.html js/dom/global-constructors-attributes-dedicated-worker.html fast/canvas/canvas-path-isPointInStroke.html fast/canvas/winding-enumeration.html fast/canvas/canvas-fill-path.html fast/canvas/canvas-path-addPath.html fast/canvas/canvas-clip-path.html fast/canvas/canvas-path-isPointInPath.html
Created attachment 319748 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Created attachment 319749 [details] Patch
Created attachment 319750 [details] Patch
Comment on attachment 319750 [details] Patch Rejecting attachment 319750 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 319750, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: anvas/recording-2d-expected.txt patching file LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt patching file LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-dedicated-worker-expected.txt patching file LayoutTests/platform/wpe/js/dom/global-constructors-attributes-dedicated-worker-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4443715
Committed r221598: <http://trac.webkit.org/changeset/221598>
Comment on attachment 319750 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319750&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:589 > + CanvasLineJoin join; > + if (stringValue == "round") > + join = CanvasLineJoin::Round; > + if (stringValue == "bevel") > + join = CanvasLineJoin::Bevel; > + if (stringValue == "miter") > + join = CanvasLineJoin::Miter; > + else > + return; Something seems wrong here. Should this be an else/if chain? Otherwise `round` and `bevel` do nothing above.
(In reply to Joseph Pecoraro from comment #14) > Comment on attachment 319750 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319750&action=review > > > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:589 > > + CanvasLineJoin join; > > + if (stringValue == "round") > > + join = CanvasLineJoin::Round; > > + if (stringValue == "bevel") > > + join = CanvasLineJoin::Bevel; > > + if (stringValue == "miter") > > + join = CanvasLineJoin::Miter; > > + else > > + return; > > Something seems wrong here. Should this be an else/if chain? Otherwise > `round` and `bevel` do nothing above. Good find Joe! Filed https://bugs.webkit.org/show_bug.cgi?id=176461 to track and fix this.
<rdar://problem/34694219>