Bug 180848 - check-webkit-style: Stop warning about underscores in webrtc source
Summary: check-webkit-style: Stop warning about underscores in webrtc source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-14 16:45 PST by David Kilzer (:ddkilzer)
Modified: 2017-12-14 19:28 PST (History)
8 users (show)

See Also:


Attachments
Patch v1 (1.56 KB, patch)
2017-12-14 16:48 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v2 (1.50 KB, patch)
2017-12-14 16:52 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-12-14 16:45:05 PST
Warnings about underscores in function names in webrtc code should be suppressed.
Comment 1 David Kilzer (:ddkilzer) 2017-12-14 16:48:51 PST
Created attachment 329421 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2017-12-14 16:52:32 PST
Created attachment 329423 [details]
Patch v2
Comment 3 Joseph Pecoraro 2017-12-14 19:04:55 PST
Comment on attachment 329423 [details]
Patch v2

rs=me
Comment 4 Joseph Pecoraro 2017-12-14 19:05:40 PST
Comment on attachment 329423 [details]
Patch v2

r=me. You changed the existing comment. Did you want to keep both?
Comment 5 Joseph Pecoraro 2017-12-14 19:06:08 PST
Comment on attachment 329423 [details]
Patch v2

Oh it said `and`! cq+
Comment 6 WebKit Commit Bot 2017-12-14 19:26:31 PST
Comment on attachment 329423 [details]
Patch v2

Clearing flags on attachment: 329423

Committed r225957: <https://trac.webkit.org/changeset/225957>
Comment 7 WebKit Commit Bot 2017-12-14 19:26:33 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-14 19:28:10 PST
<rdar://problem/36065806>