Bug 181369 - Fix check-webkit-style issues with WebNSDataExtras.mm
Summary: Fix check-webkit-style issues with WebNSDataExtras.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 181256
Blocks:
  Show dependency tree / graph
 
Reported: 2018-01-06 20:26 PST by David Kilzer (:ddkilzer)
Modified: 2018-01-08 13:03 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (18.35 KB, patch)
2018-01-08 02:20 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2018-01-06 20:26:29 PST 
After converting Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m to Objective-C++ for Bug 181256, the check-webkit-style script finds a number of issues with its coding style.

This bug tracks fixing all the known style issues found with check-webkit-style.
Comment 1 David Kilzer (:ddkilzer) 2018-01-08 02:20:54 PST 
Created attachment 330672 [details]
Patch v1
Comment 2 WebKit Commit Bot 2018-01-08 13:02:09 PST 
Comment on attachment 330672 [details]
Patch v1

Clearing flags on attachment: 330672

Committed r226529: <https://trac.webkit.org/changeset/226529>
Comment 3 WebKit Commit Bot 2018-01-08 13:02:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-01-08 13:03:29 PST 
<rdar://problem/36357331>