I get the following errors: $ check-webkit-style ERROR: Source/WebCore/loader/ResourceLoadObserver.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/loader/ResourceLoadObserver.cpp:317: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:748: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:749: Missing space before { [whitespace/braces] [5] ... on lines like: #define LOCAL_LOG(str, ...) \ RELEASE_LOG(ResourceLoadStatistics, "ResourceLoadObserver::logUserInteraction: counter = %" PRIu64 ": " str, counter, ##__VA_ARGS__) LOCAL_LOG(R"({ "url": "%{public}s",)", escapedURL.utf8().data()); LOCAL_LOG(R"( "domain" : "%{public}s",)", escapedDomain.utf8().data()); check-webkit-style appears to be stumbling over the {}'s in the print specification (that is, the "%s{public}s"). The use of {public} in the format string is an extension used by os_log() to the standard C/C++ format string specification.
Created attachment 331276 [details] Patch v1
Comment on attachment 331276 [details] Patch v1 Clearing flags on attachment: 331276 Committed r226938: <https://trac.webkit.org/changeset/226938>
All reviewed patches have been landed. Closing bug.
<rdar://problem/36498700>