Bug 182015 - check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
Summary: check-webkit-style reports false-positive whitespace/braces warning about blo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-23 14:44 PST by David Kilzer (:ddkilzer)
Modified: 2018-01-24 10:11 PST (History)
7 users (show)

See Also:


Attachments
Patch v1 (2.51 KB, patch)
2018-01-23 14:55 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.01 MB, application/zip)
2018-01-23 19:02 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2018-01-23 14:44:06 PST
This code which contains a block argument with a return type:

    [delegate setPolicyForURL:^_WKWebsitePolicy(NSURL *url) {
        return _WKWebsitePolicyDoIt;
    }];

Triggers a false-positive warning like this:

    Place brace on its own line for function definitions.  [whitespace/braces] [4]
Comment 1 David Kilzer (:ddkilzer) 2018-01-23 14:44:14 PST
<rdar://problem/36449728>
Comment 2 David Kilzer (:ddkilzer) 2018-01-23 14:55:25 PST
Created attachment 332081 [details]
Patch v1
Comment 3 EWS Watchlist 2018-01-23 19:02:21 PST
Comment on attachment 332081 [details]
Patch v1

Attachment 332081 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6189452

New failing tests:
http/tests/misc/bubble-drag-events.html
Comment 4 EWS Watchlist 2018-01-23 19:02:31 PST
Created attachment 332117 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 David Kilzer (:ddkilzer) 2018-01-24 09:59:30 PST
(In reply to Build Bot from comment #3)
> Comment on attachment 332081 [details]
> Patch v1
> 
> Attachment 332081 [details] did not pass win-ews (win):
> Output: http://webkit-queues.webkit.org/results/6189452
> 
> New failing tests:
> http/tests/misc/bubble-drag-events.html

FYI: There is no possible way this patch can cause a Windows layout test failure as it only changes Python code used by check-webkit-style.
Comment 6 WebKit Commit Bot 2018-01-24 10:11:18 PST
Comment on attachment 332081 [details]
Patch v1

Clearing flags on attachment: 332081

Committed r227532: <https://trac.webkit.org/changeset/227532>
Comment 7 WebKit Commit Bot 2018-01-24 10:11:20 PST
All reviewed patches have been landed.  Closing bug.