Bug 184554 - Implement checked cast for DDResultRef once DDResultGetCFTypeID() is available
Summary: Implement checked cast for DDResultRef once DDResultGetCFTypeID() is available
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-12 13:03 PDT by David Kilzer (:ddkilzer)
Modified: 2018-06-07 15:55 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.34 KB, patch)
2018-04-12 13:09 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (2.45 KB, patch)
2018-05-29 15:53 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v3 (2.45 KB, patch)
2018-05-29 15:55 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2018-04-12 13:03:07 PDT 
Implement checked cast for DDResultRef once DDResultGetTypeID() is available.
Comment 1 David Kilzer (:ddkilzer) 2018-04-12 13:03:15 PDT 
<rdar://problem/36241894>
Comment 2 David Kilzer (:ddkilzer) 2018-04-12 13:09:15 PDT 
Created attachment 337828 [details]
Patch
Comment 3 Brent Fulgham 2018-04-17 09:20:28 PDT 
Comment on attachment 337828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337828&action=review

r=me

> Source/WebCore/editing/cocoa/DataDetection.mm:87
> +        DDResultRef result = checked_cf_cast<DDResultRef>(CFArrayGetValueAtIndex(results.get(), i));

Nice!
Comment 4 WebKit Commit Bot 2018-04-17 09:28:40 PDT 
Comment on attachment 337828 [details]
Patch

Clearing flags on attachment: 337828

Committed r230713: <https://trac.webkit.org/changeset/230713>
Comment 5 WebKit Commit Bot 2018-04-17 09:28:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Matt Lewis 2018-04-17 10:03:07 PDT 
Reverted r230713 for reason:

This caused internal build failures.

Committed r230716: <https://trac.webkit.org/changeset/230716>
Comment 7 David Kilzer (:ddkilzer) 2018-05-29 15:53:04 PDT 
Created attachment 341530 [details]
Patch v2
Comment 8 David Kilzer (:ddkilzer) 2018-05-29 15:55:27 PDT 
Created attachment 341531 [details]
Patch v3
Comment 9 David Kilzer (:ddkilzer) 2018-05-31 11:12:01 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #8)
> Created attachment 341531 [details]
> Patch v3

Going to land v3 with Brent's previous review as I fixed the build failure on internal bots, and the patch is not materially different.
Comment 10 Brent Fulgham 2018-05-31 11:15:56 PDT 
Comment on attachment 341531 [details]
Patch v3

I still approve of this patch! r=me.
Comment 11 WebKit Commit Bot 2018-05-31 12:33:44 PDT 
Comment on attachment 341531 [details]
Patch v3

Clearing flags on attachment: 341531

Committed r232362: <https://trac.webkit.org/changeset/232362>
Comment 12 WebKit Commit Bot 2018-05-31 12:33:46 PDT 
All reviewed patches have been landed.  Closing bug.