Bug 185100 - Add logging when SpringBoard enables WebThread
Summary: Add logging when SpringBoard enables WebThread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-27 17:13 PDT by David Kilzer (:ddkilzer)
Modified: 2018-06-18 18:33 PDT (History)
9 users (show)

See Also:

Attachments
Patch v1 (5.57 KB, patch)
2018-04-27 17:19 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (5.82 KB, patch)
2018-04-27 20:30 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2018-04-27 17:13:18 PDT 
Add logging when SpringBoard enables WebThread.

<rdar://problem/39746542>
Comment 1 David Kilzer (:ddkilzer) 2018-04-27 17:19:08 PDT 
Created attachment 339043 [details]
Patch v1
Comment 2 Daniel Bates 2018-04-27 19:34:59 PDT 
Comment on attachment 339043 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=339043&action=review

> Source/WTF/ChangeLog:5
> +        <rdar://problem/39746542>

I assume if I were to look at this bug that it would explain why it is beneficial to add this logging.

> Source/WTF/wtf/Platform.h:-1266
> -/* FIXME: Enable USE_OS_LOG when building with the public iOS 10 SDK once we fix <rdar://problem/27758343>. */

Not at my computer. I am assuming we fixed the referenced radar and hence we can enable this. The ChangeLog didn’t mention this fact and EWS failed to compile this patch for iOS due to another issue below.

> Source/WebCore/platform/ios/wak/WebCoreThread.mm:880
> +        RELEASE_LOG_FAULT(Threading, "SpringBoard enabled WebThread.");

According to the EWS we don’t have a logging channel called Threading.
Comment 3 David Kilzer (:ddkilzer) 2018-04-27 20:14:16 PDT 
Comment on attachment 339043 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=339043&action=review

>> Source/WTF/ChangeLog:5
>> +        <rdar://problem/39746542>
> 
> I assume if I were to look at this bug that it would explain why it is beneficial to add this logging.

Correct.  Added more detail just now as well.

>> Source/WTF/wtf/Platform.h:-1266
>> -/* FIXME: Enable USE_OS_LOG when building with the public iOS 10 SDK once we fix <rdar://problem/27758343>. */
> 
> Not at my computer. I am assuming we fixed the referenced radar and hence we can enable this. The ChangeLog didn’t mention this fact and EWS failed to compile this patch for iOS due to another issue below.

Yes, it's fixed.  I'll add a comment to the ChangeLog.

>> Source/WebCore/platform/ios/wak/WebCoreThread.mm:880
>> +        RELEASE_LOG_FAULT(Threading, "SpringBoard enabled WebThread.");
> 
> According to the EWS we don’t have a logging channel called Threading.

Weird.  I thought it was defined here:  Source/WebCore/platform/Logging.h

Maybe I forgot to #include that.
Comment 4 David Kilzer (:ddkilzer) 2018-04-27 20:30:15 PDT 
Created attachment 339053 [details]
Patch v2
Comment 5 David Kilzer (:ddkilzer) 2018-04-27 20:38:37 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #4)
> Created attachment 339053 [details]
> Patch v2

Added missing #import "Logging.h" to WebCoreThread.mm to fix the iOS build failures.

Also updated Source/WTF/ChangeLog with info about the fixed radar.
Comment 6 WebKit Commit Bot 2018-04-27 22:53:09 PDT 
Comment on attachment 339053 [details]
Patch v2

Clearing flags on attachment: 339053

Committed r231130: <https://trac.webkit.org/changeset/231130>
Comment 7 WebKit Commit Bot 2018-04-27 22:53:10 PDT 
All reviewed patches have been landed.  Closing bug.