Bug 187224 - Fix clang static analyzer warnings: Garbage return value
Summary: Fix clang static analyzer warnings: Garbage return value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-30 14:41 PDT by David Kilzer (:ddkilzer)
Modified: 2018-06-30 19:13 PDT (History)
10 users (show)

See Also:

Attachments
Patch v1 (11.60 KB, patch)
2018-06-30 14:47 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2018-06-30 14:41:44 PDT 
Fix clang static analyzer warnings: Garbage return value.
Comment 1 Radar WebKit Bug Importer 2018-06-30 14:42:08 PDT 
<rdar://problem/41683170>
Comment 2 David Kilzer (:ddkilzer) 2018-06-30 14:47:25 PDT 
Created attachment 344023 [details]
Patch v1
Comment 3 Eric Carlson 2018-06-30 16:39:03 PDT 
Comment on attachment 344023 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=344023&action=review

> Source/WebCore/platform/mediastream/MediaConstraints.h:245
>          ValueType max = capabilityMax;

Ditto
Comment 4 WebKit Commit Bot 2018-06-30 17:06:45 PDT 
Comment on attachment 344023 [details]
Patch v1

Clearing flags on attachment: 344023

Committed r233403: <https://trac.webkit.org/changeset/233403>
Comment 5 WebKit Commit Bot 2018-06-30 17:06:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 David Kilzer (:ddkilzer) 2018-06-30 17:44:06 PDT 
Comment on attachment 344023 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=344023&action=review

>> Source/WebCore/platform/mediastream/MediaConstraints.h:245
>>          ValueType max = capabilityMax;
> 
> Ditto

What did you mean here?  Did you want me to change these lines to this?

        ValueType min { capabilityMin };
        ValueType max { capabilityMax };
Comment 7 David Kilzer (:ddkilzer) 2018-06-30 19:13:00 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #6)
> Comment on attachment 344023 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344023&action=review
> 
> >> Source/WebCore/platform/mediastream/MediaConstraints.h:245
> >>          ValueType max = capabilityMax;
> > 
> > Ditto
> 
> What did you mean here?  Did you want me to change these lines to this?
> 
>         ValueType min { capabilityMin };
>         ValueType max { capabilityMax };

Follow-up fix committed here:

Committed r233406: <https://trac.webkit.org/changeset/233403>