Bug 188725 - REGRESSION (r234396): Leak of CFURLRef in WebKit::NetworkProcess::deleteHSTSCacheForHostNames()
Summary: REGRESSION (r234396): Leak of CFURLRef in WebKit::NetworkProcess::deleteHSTSC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 187379
Blocks:
  Show dependency tree / graph
 
Reported: 2018-08-18 16:48 PDT by David Kilzer (:ddkilzer)
Modified: 2018-08-19 08:16 PDT (History)
6 users (show)

See Also:

Attachments
Patch v1 (2.00 KB, patch)
2018-08-18 16:50 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2018-08-18 16:48:03 PDT 
Leak of CFURLRef in WebKit::NetworkProcess::deleteHSTSCacheForHostNames():

void NetworkProcess::deleteHSTSCacheForHostNames(WebCore::NetworkStorageSession& session, const Vector<String>& hostNames)
{
    for (auto& hostName : hostNames)
        _CFNetworkResetHSTS(CFURLCreateWithString(kCFAllocatorDefault, hostName.createCFString().get(), NULL), session.platformSession());
}

Found by internal static analyzer bot.
Comment 1 Radar WebKit Bug Importer 2018-08-18 16:48:18 PDT 
<rdar://problem/43469670>
Comment 2 David Kilzer (:ddkilzer) 2018-08-18 16:50:46 PDT 
Created attachment 347453 [details]
Patch v1
Comment 3 WebKit Commit Bot 2018-08-19 08:16:56 PDT 
Comment on attachment 347453 [details]
Patch v1

Clearing flags on attachment: 347453

Committed r235016: <https://trac.webkit.org/changeset/235016>
Comment 4 WebKit Commit Bot 2018-08-19 08:16:57 PDT 
All reviewed patches have been landed.  Closing bug.