Bug 189574 - Move JavaScriptCore files to match Xcode project hierarchy
Summary: Move JavaScriptCore files to match Xcode project hierarchy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-12 21:23 PDT by David Kilzer (:ddkilzer)
Modified: 2018-09-13 06:41 PDT (History)
10 users (show)

See Also:


Attachments
Patch v1 (118.87 KB, patch)
2018-09-12 21:26 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v2 (112.52 KB, patch)
2018-09-12 21:27 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v3 (113.07 KB, patch)
2018-09-12 21:49 PDT, David Kilzer (:ddkilzer)
fpizlo: review+
ddkilzer: commit-queue-
Details | Formatted Diff | Diff
Patch v4 (for landing if it builds) (113.69 KB, patch)
2018-09-12 22:38 PDT, David Kilzer (:ddkilzer)
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.60 MB, application/zip)
2018-09-13 04:10 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.55 MB, application/zip)
2018-09-13 05:38 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2018-09-12 21:23:17 PDT
Move JavaScriptCore files to match Xcode project hierarchy.

These changes will let us turn "virtual" folders into folders that are backed by a directory in the project.

The changes can be summarized as follows:

Source/JavaScriptCore/runtime/JSAPIValueWrapper.cpp => Source/JavaScriptCore/API/JSAPIValueWrapper.cpp
Source/JavaScriptCore/runtime/JSAPIValueWrapper.h => Source/JavaScriptCore/API/JSAPIValueWrapper.h
Source/JavaScriptCore/Scripts/generateYarrUnicodePropertyTables.py => Source/JavaScriptCore/yarr/generateYarrUnicodePropertyTables.py
Source/JavaScriptCore/Scripts/hasher.py => Source/JavaScriptCore/yarr/hasher.py

Fallout from the changes includes:
- Updating the Xcode project file to point to the new locations.
- Adding hasher.py (previously omitted) to the Xcode project file.
- Updating CMakeLists.txt, DerivedSources.make and Sources.txt for new locations.
- Updating Source/JavaScriptCore/runtime/JSImmutableButterfly.h and Source/JavaScriptCore/runtime/RuntimeType.h to build within regenerated UnifiedSources (missing headers that were previously included in JSAPIValueWrapper.{cpp,h}).
Comment 1 David Kilzer (:ddkilzer) 2018-09-12 21:24:22 PDT
NOTE: All moved files are 100% the same after the move.
Comment 2 David Kilzer (:ddkilzer) 2018-09-12 21:26:21 PDT
Created attachment 349623 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2018-09-12 21:27:16 PDT
Created attachment 349624 [details]
Patch v2
Comment 4 David Kilzer (:ddkilzer) 2018-09-12 21:27:52 PDT
(In reply to David Kilzer (:ddkilzer) from comment #2)
> Created attachment 349623 [details]
> Patch v1

Oops, this included a minor clean-up that I'm going to commit separately.
Comment 5 David Kilzer (:ddkilzer) 2018-09-12 21:45:10 PDT
Comment on attachment 349624 [details]
Patch v2

Sigh, looks like this will need more header fixes, or clean builds.
Comment 6 David Kilzer (:ddkilzer) 2018-09-12 21:49:20 PDT
Created attachment 349626 [details]
Patch v3

Fix path to JSAPIValueWrapper.h in CMakeLists.txt.
Comment 7 Filip Pizlo 2018-09-12 22:09:38 PDT
Rs=me for fixes to the rest of the fallout.
Comment 8 David Kilzer (:ddkilzer) 2018-09-12 22:38:13 PDT
Created attachment 349629 [details]
Patch v4 (for landing if it builds)

Fix path to hasher.py in CMakeLists.txt, and add missing dependency on hasher.py to DerivedSources.make.
Comment 9 EWS Watchlist 2018-09-13 00:14:02 PDT
Comment on attachment 349629 [details]
Patch v4 (for landing if it builds)

Attachment 349629 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/9199964

New failing tests:
stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager
apiTests
Comment 10 EWS Watchlist 2018-09-13 04:10:22 PDT
Comment on attachment 349629 [details]
Patch v4 (for landing if it builds)

Attachment 349629 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9201508

New failing tests:
accessibility/smart-invert-reference.html
Comment 11 EWS Watchlist 2018-09-13 04:10:24 PDT
Created attachment 349652 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 12 EWS Watchlist 2018-09-13 05:38:38 PDT
Comment on attachment 349629 [details]
Patch v4 (for landing if it builds)

Attachment 349629 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9201842

New failing tests:
fast/animation/css-animation-resuming-when-visible-with-style-change2.html
Comment 13 EWS Watchlist 2018-09-13 05:38:39 PDT
Created attachment 349658 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 14 David Kilzer (:ddkilzer) 2018-09-13 06:40:43 PDT
Committed r235972: <https://trac.webkit.org/changeset/235972>
Comment 15 Radar WebKit Bug Importer 2018-09-13 06:41:23 PDT
<rdar://problem/44415797>