Fix build failure on watchOS: error: reference to 'KeyType' is ambiguous A header in IMFoundation.framework and `using WebCore::IndexedDB::KeyType` in Source/WebCore/Modules/indexeddb/IDBKey.h are conflicting with unified source files. Note that r235954 was rolled out in r235995, so this isn't needed until r235954 is relanded: https://trac.webkit.org/changeset/235995/webkit
I have a fix. Sorry I didn't get it prepped in time.
Created attachment 349714 [details] Patch v1
Created attachment 349725 [details] Patch v2
(In reply to David Kilzer (:ddkilzer) from comment #3) > Created attachment 349725 [details] > Patch v2 Thanks for doing this! Do you think I should merge it into r235954, or you commit this before my resubmitting r235954?
(In reply to Sihui Liu from comment #4) > (In reply to David Kilzer (:ddkilzer) from comment #3) > > Created attachment 349725 [details] > > Patch v2 > > Thanks for doing this! Do you think I should merge it into r235954, or you > commit this before my resubmitting r235954? I would commit it separately. Makes it easier to roll-in/roll-out r235954 just in case there's another build failure.
(In reply to David Kilzer (:ddkilzer) from comment #5) > (In reply to Sihui Liu from comment #4) > > (In reply to David Kilzer (:ddkilzer) from comment #3) > > > Created attachment 349725 [details] > > > Patch v2 > > > > Thanks for doing this! Do you think I should merge it into r235954, or you > > commit this before my resubmitting r235954? > > I would commit it separately. Makes it easier to roll-in/roll-out r235954 > just in case there's another build failure. Great! Thanks.
Comment on attachment 349725 [details] Patch v2 r=me
Comment on attachment 349725 [details] Patch v2 Clearing flags on attachment: 349725 Committed r236007: <https://trac.webkit.org/changeset/236007>
All reviewed patches have been landed. Closing bug.
<rdar://problem/44459094>