Bug 191857 - [iOS] Scrollbar size in iOS platforms
Summary: [iOS] Scrollbar size in iOS platforms
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-20 03:14 PST by Manuel Rego Casasnovas
Modified: 2018-11-21 06:43 PST (History)
5 users (show)

See Also:


Attachments
Patch for checking iOS EWS (2.26 KB, patch)
2018-11-20 23:45 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Trying horizontalScrollbarIntrusion() as suggested by fwang (2.29 KB, patch)
2018-11-21 01:10 PST, Manuel Rego Casasnovas
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.63 MB, application/zip)
2018-11-21 06:43 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2018-11-20 03:14:03 PST
As discussed in bug #191656 it might be needed that scrollbarLogicalWidth() and scrollbarLogicalHeight() returns zero on iOS.

Some weird issues on iOS caused that the patch for #191656 got rollout, to make it pass all tests in iOS and iOS Simulator.
To fix it temporary we added a "#if !PLATFORM(IOS_FAMILY)" there.
Comment 1 Simon Fraser (smfr) 2018-11-20 17:13:10 PST
Does scrollbarIntrusion() do what you want?
Comment 2 Manuel Rego Casasnovas 2018-11-20 23:45:06 PST
Created attachment 355390 [details]
Patch for checking iOS EWS
Comment 3 Frédéric Wang (:fredw) 2018-11-20 23:58:51 PST
Comment on attachment 355390 [details]
Patch for checking iOS EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=355390&action=review

> Source/WebCore/rendering/RenderGrid.cpp:1011
> +        borderAndPadding += layer()->scrollbarIntrusion().width();

I guess you can just use layer()->horizontalScrollbarIntrusion()?
Comment 4 Manuel Rego Casasnovas 2018-11-21 01:10:04 PST
Created attachment 355394 [details]
Trying horizontalScrollbarIntrusion() as suggested by fwang
Comment 5 Frédéric Wang (:fredw) 2018-11-21 05:52:30 PST
The tests seems to render fine for me when running directly in the Safari simulator, so I wonder whether it's something specific to the test runner.
Comment 6 EWS Watchlist 2018-11-21 06:43:55 PST
Comment on attachment 355394 [details]
Trying horizontalScrollbarIntrusion() as suggested by fwang

Attachment 355394 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10098603

New failing tests:
imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html
Comment 7 EWS Watchlist 2018-11-21 06:43:57 PST
Created attachment 355409 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6