RESOLVED FIXED 192661
clang-tidy: loop variable is copied but only used as const reference in Document.cpp, Element.cpp 
https://bugs.webkit.org/show_bug.cgi?id=192661
Summary clang-tidy: loop variable is copied but only used as const reference in Docum...
David Kilzer (:ddkilzer)
Reported 2018-12-13 04:10:30 PST
Running `clang-tidy '-checks=-*,performance-for-range-copy' ...` on Document.cpp and Element.cpp finds these unnecessary copies: Source/WebCore/dom/Document.cpp:7907:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy] for (auto observer : m_intersectionObserversWithPendingNotifications) { ^ const & Source/WebCore/dom/Element.cpp:1777:19: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy] for (auto observer : observerData->observers) { ^ const & Source/WebCore/dom/Element.cpp:3399:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy] for (auto observer : observerData->observers) ^ const &
Attachments
Patch v1 (3.35 KB, patch)
2018-12-13 05:33 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-13 04:11:29 PST
<rdar://problem/46694035>
David Kilzer (:ddkilzer)
Comment 2 2018-12-13 05:33:03 PST
Created attachment 357226 [details] Patch v1
WebKit Commit Bot
Comment 3 2018-12-13 06:44:36 PST
Comment on attachment 357226 [details] Patch v1 Clearing flags on attachment: 357226 Committed r239160: <https://trac.webkit.org/changeset/239160>
WebKit Commit Bot
Comment 4 2018-12-13 06:44:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.