Bug 193649 - Move delegatesScrolling() tests to lower level conversion function in ScrollView
Summary: Move delegatesScrolling() tests to lower level conversion function in ScrollView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-21 01:45 PST by Antti Koivisto
Modified: 2019-03-11 17:51 PDT (History)
11 users (show)

See Also:

Attachments
patch (9.94 KB, patch)
2019-01-21 01:52 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (8.23 KB, patch)
2019-01-21 02:14 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-01-21 01:45:04 PST 
They should be in viewToContents/contentsToView functions.
Comment 1 Antti Koivisto 2019-01-21 01:52:51 PST 
Created attachment 359678 [details]
patch
Comment 2 Antti Koivisto 2019-01-21 02:14:58 PST 
Created attachment 359679 [details]
patch
Comment 3 Frédéric Wang (:fredw) 2019-01-21 03:04:28 PST 
Comment on attachment 359679 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359679&action=review

This LGTMs, thanks!

> Source/WebCore/platform/ScrollView.cpp:-864
> -    

This is reverting what was added in bug 186956. I guess your patch is the right way to fix it.

> Source/WebCore/platform/ScrollView.cpp:-877
> -

I'm curious if this will fix bug 184297 as the patch I uploaded there does similar thing.
Comment 4 Antti Koivisto 2019-01-21 03:45:45 PST 
Comment on attachment 359679 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359679&action=review

>> Source/WebCore/platform/ScrollView.cpp:-864
>> -    
> 
> This is reverting what was added in bug 186956. I guess your patch is the right way to fix it.

Yeah, the result should be the same.
Comment 5 WebKit Commit Bot 2019-01-21 04:27:58 PST 
Comment on attachment 359679 [details]
patch

Clearing flags on attachment: 359679

Committed r240232: <https://trac.webkit.org/changeset/240232>
Comment 6 WebKit Commit Bot 2019-01-21 04:28:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-01-21 04:28:29 PST 
<rdar://problem/47427108>