vp8e_mr_alloc_mem() leaks LOWER_RES_FRAME_INFO if second memory allocation fails via clang static analyzer: Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:589:5: warning: Value stored to 'res' is never read res = VPX_CODEC_MEM_ERROR; ^ ~~~~~~~~~~~~~~~~~~~ Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:592:27: warning: Access to field 'mb_info' results in a dereference of a null pointer (loaded from variable 'shared_mem_loc') shared_mem_loc->mb_info = ~~~~~~~~~~~~~~ ^ Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:595:11: warning: Potential leak of memory pointed to by 'shared_mem_loc' res = VPX_CODEC_MEM_ERROR; ^~~~~~~~~~~~~~~~~~~ 3 warnings generated.
Created attachment 361148 [details] Patch v1
<rdar://problem/47808154>
Comment on attachment 361148 [details] Patch v1 Clearing flags on attachment: 361148 Committed r240961: <https://trac.webkit.org/changeset/240961>
All reviewed patches have been landed. Closing bug.