Bug 196897 - [ews-build] Do not run clean build by default on EWS builders
Summary: [ews-build] Do not run clean build by default on EWS builders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-13 06:23 PDT by Aakash Jain
Modified: 2019-04-15 13:13 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.10 KB, patch)
2019-04-13 08:06 PDT, Aakash Jain
lforschler: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-04-13 06:23:00 PDT
Builders on ews-build don't need to run clean builds. Incremental builds are fine for EWS. clean builds take a lot longer without much value addition for EWS. Old EWS also doesn't run clean builds, ews-build should do the same.

ews-build is currently running clean builds (even though we have not explicitly specified clean build in our configuration).
Comment 1 Alexey Proskuryakov 2019-04-13 07:27:52 PDT
To elaborate on old EWS behavior, it dies build clean when retrying. Otherwise, changes that require clean rebuild would be breaking EWS permanently, until manual intervention.
Comment 2 Aakash Jain 2019-04-13 08:06:12 PDT
(In reply to Alexey Proskuryakov from comment #1)
> To elaborate on old EWS behavior, it does build clean when retrying.
> Otherwise, changes that require clean rebuild would be breaking EWS permanently, until manual intervention.
Yes, we will continue to do clean build on retry (unapply-patch step removes untracked files including WebKitBuild directory).
Comment 3 Aakash Jain 2019-04-13 08:06:44 PDT
Created attachment 367387 [details]
Patch
Comment 4 Lucas Forschler 2019-04-15 13:02:46 PDT
Comment on attachment 367387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367387&action=review

> Tools/ChangeLog:10
> +        file is present, during the Source checkout, Buildbot clean the working directory completely (including removing 

nit: buildbot cleans
Comment 5 Aakash Jain 2019-04-15 13:12:42 PDT
Committed r244283: <https://trac.webkit.org/changeset/244283>
Comment 6 Radar WebKit Bug Importer 2019-04-15 13:13:22 PDT
<rdar://problem/49914488>