When there is only 1 api test failure, currently the failure string reads: 'Found 1 new API Tests failures'. It should be singular for single failure. e.g.: https://ews-build.webkit.org/#/builders/3/builds/670
Created attachment 367633 [details] Patch
Comment on attachment 367633 [details] Patch I think we have a webkitpy pluralize function. This is pretty lightweight, so so don't expect you to import webkitpy, but I'm curious if the logic you used was similar?
Comment on attachment 367633 [details] Patch > I think we have a webkitpy pluralize function. This is pretty lightweight, > so so don't expect you to import webkitpy, but I'm curious if the logic you > used was similar? The logic is similar. webkitpy method (https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/grammar.py#L41) is little more generic and take care of whether to append 's' vs 'es'. I don't think we need to make a generic function here.
Comment on attachment 367633 [details] Patch Clearing flags on attachment: 367633 Committed r244504: <https://trac.webkit.org/changeset/244504>
All reviewed patches have been landed. Closing bug.
<rdar://problem/50100796>