Bug 197013 - [ews-build] Use singular verb in failure description in case of single api test failure
Summary: [ews-build] Use singular verb in failure description in case of single api te...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-17 08:59 PDT by Aakash Jain
Modified: 2019-04-22 11:30 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.13 KB, patch)
2019-04-17 09:10 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-04-17 08:59:41 PDT
When there is only 1 api test failure, currently the failure string reads: 'Found 1 new API Tests failures'. It should be singular for single failure.

e.g.: https://ews-build.webkit.org/#/builders/3/builds/670
Comment 1 Aakash Jain 2019-04-17 09:10:18 PDT
Created attachment 367633 [details]
Patch
Comment 2 Lucas Forschler 2019-04-17 09:15:10 PDT
Comment on attachment 367633 [details]
Patch

I think we have a webkitpy pluralize function. This is pretty lightweight, so so don't expect you to import webkitpy, but I'm curious if the logic you used was similar?
Comment 3 Aakash Jain 2019-04-22 06:06:19 PDT
Comment on attachment 367633 [details]
Patch

> I think we have a webkitpy pluralize function. This is pretty lightweight,
> so so don't expect you to import webkitpy, but I'm curious if the logic you
> used was similar?
The logic is similar. webkitpy method (https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/grammar.py#L41) is little more generic and take care of whether to append 's' vs 'es'. I don't think we need to make a generic function here.
Comment 4 WebKit Commit Bot 2019-04-22 11:29:45 PDT
Comment on attachment 367633 [details]
Patch

Clearing flags on attachment: 367633

Committed r244504: <https://trac.webkit.org/changeset/244504>
Comment 5 WebKit Commit Bot 2019-04-22 11:29:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-04-22 11:30:32 PDT
<rdar://problem/50100796>