Steps to reproduce the problem: 1. write a short document with an element having specified 'grid-template-columns' property to 'repeat(2, [e] 40px)' through a style rule 2. query, through the CSS OM, the specified value for that property on that element 3. show the value Here's a reduced testcase: <!DOCTYPE html> <body> <script> document.body.style.gridTemplateColumns = "repeat(2, [e] 40px)" console.log(document.body.style.gridTemplateColumns); </script> What is the expected behavior? The value should be the specified value, exactly. What went wrong? The displayed value is `[e] 40px [e] 40px` ; that behaviour breaks CSS editor that want to preserve precisely what the CSS author specified. Has been fixed in Blink: https://crbug.com/716114
Created attachment 369742 [details] Patch
Created attachment 369747 [details] Patch
Created attachment 369762 [details] Patch
Created attachment 369785 [details] Patch
Created attachment 369804 [details] Patch
Comment on attachment 369804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369804&action=review > Source/WebCore/css/parser/CSSPropertyParser.cpp:3432 > + list.append(*integerRepeatedValues); I think you should use integerRepeatedValues.releaseNonNull() instead of deref the RefPtr > Tools/TestWebKitAPI/Tests/WebCore/CSSParser.cpp:28 > +#include <WebCore/CSSGridIntegerRepeatValue.h> The CSSGridIntegerRepeatValue.h is under the WebCore/css folder.
Comment on attachment 369804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369804&action=review >> Source/WebCore/css/parser/CSSPropertyParser.cpp:3432 >> + list.append(*integerRepeatedValues); > > I think you should use integerRepeatedValues.releaseNonNull() instead of deref the RefPtr You are right, thanks >> Tools/TestWebKitAPI/Tests/WebCore/CSSParser.cpp:28 >> +#include <WebCore/CSSGridIntegerRepeatValue.h> > > The CSSGridIntegerRepeatValue.h is under the WebCore/css folder. But if I use WebCore/css/CSSGridIntegerRepeatValue.h, it doesn't compile locally. And for example the StyleProperties.h below is also inside the css folder
Created attachment 369887 [details] Patch
I added "settings = {ATTRIBUTES = (Private, ); };" in project.pbxproj, now it seems to compile on Mac.
Comment on attachment 369887 [details] Patch Thanks for fixing this.
Comment on attachment 369887 [details] Patch Clearing flags on attachment: 369887 Committed r245798: <https://trac.webkit.org/changeset/245798>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51163602>