``` console.assert(false, "foo"); ``` should be stripped ``` let x = "console.assert(false);" ``` should not be stripped
Created attachment 370546 [details] Patch
Created attachment 370547 [details] Patch
Comment on attachment 370547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370547&action=review > Source/WebInspectorUI/Scripts/remove-console-asserts.pl:52 > + s/^\s*console\.assert\(.*\);\s*//g; This is nice. I approve this. > Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59 > + next if /^["'`]*console\.assert/; This doesn't do what you think it does.
Created attachment 370548 [details] Patch
Comment on attachment 370548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370548&action=review sh > Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59 > + next if /^.*?["'`].*?console\.assert/; /["'`].*?console\.assert/
Comment on attachment 370548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370548&action=review >> Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59 >> + next if /^.*?["'`].*?console\.assert/; > > /["'`].*?console\.assert/ /\/\/.*?console\.assert/
Created attachment 370553 [details] Patch
Comment on attachment 370553 [details] Patch Clearing flags on attachment: 370553 Committed r245741: <https://trac.webkit.org/changeset/245741>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51093853>