UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build. We would need to retry layout-tests in EWS. However the file name for the uploaded test results is same if there are multiple layout-tests executions. The file name includes the builder-name, patch_id and build-number, all of which are same for multiple layout-test runs in a same build. We should add an optional identifier which can be passed to these classes in order to avoid clobbering the results.
Created attachment 372810 [details] Patch
Sample run: https://ews-build.webkit-uat.org/#/builders/35/builds/11
Attachment 372810 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:1104: [ExtractTestResults.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1491: [TestUploadTestResults.test_success_with_identifier] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1491: [TestUploadTestResults.test_success_with_identifier] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1535: [TestExtractTestResults.test_success_with_identifier] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1535: [TestExtractTestResults.test_success_with_identifier] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 372810 [details] Patch Clearing flags on attachment: 372810 Committed r246793: <https://trac.webkit.org/changeset/246793>
All reviewed patches have been landed. Closing bug.
<rdar://problem/52116313>