Bug 199605 - [ews-build] Do not run unix commands for windows in PrintConfiguration
Summary: [ews-build] Do not run unix commands for windows in PrintConfiguration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-08 18:42 PDT by Aakash Jain
Modified: 2019-07-09 09:17 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2019-07-08 18:46 PDT, Aakash Jain
jbedard: review+
Details | Formatted Diff | Diff
Patch for landing (2.27 KB, patch)
2019-07-09 09:13 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-07-08 18:42:33 PDT
Do not run unix commands for windows in PrintConfiguration. For example: 'df' command is unix-specific and doesn't work on windows. 

e.g.: https://ews-build.webkit-uat.org/#/builders/10/builds/26/steps/2/logs/stdio
Comment 1 Aakash Jain 2019-07-08 18:46:43 PDT
Created attachment 373688 [details]
Patch
Comment 2 Aakash Jain 2019-07-09 09:13:08 PDT
Created attachment 373721 [details]
Patch for landing

Updated unit-tests.
Comment 3 Aakash Jain 2019-07-09 09:14:07 PDT
Committed r247258: <https://trac.webkit.org/changeset/247258>
Comment 4 Radar WebKit Bug Importer 2019-07-09 09:17:29 PDT
<rdar://problem/52836308>