Sometimes some bots gets into a state when git operations fail with an error: "fatal: Unable to create 'build/.git/index.lock': File exists." , e.g.: https://ews-build.webkit-uat.org/#/builders/40/builds/177 This usually happens when a git operation is interrupted (e.g.: by buildbot restart while git operation was running). Once that happens bot can't recover themself, and they burn through all the build-requests very quickly. This is pretty bad. To make EWS robust against such issues, we should add build step to delete .git/index.lock file.
Created attachment 373945 [details] Patch
Sample run: https://ews-build.webkit-uat.org/#/builders/40/builds/193
Attachment 373945 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:105: [CheckOutSource.getResultSummary] Instance of 'CheckOutSource' has no 'results' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:119: [CleanUpGitIndexLock.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:122: [CleanUpGitIndexLock.evaluateCommand] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:499: [TestCleanUpGitIndexLock.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:499: [TestCleanUpGitIndexLock.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:513: [TestCleanUpGitIndexLock.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:513: [TestCleanUpGitIndexLock.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 7 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 373945 [details] Patch Clearing flags on attachment: 373945 Committed r247364: <https://trac.webkit.org/changeset/247364>
All reviewed patches have been landed. Closing bug.
<rdar://problem/52971180>
Small follow-up fix: https://trac.webkit.org/changeset/247372/webkit Missed this while creating the patch previously.