The Geolocation API specification renamed the following interfaces and removed the [NoInterfaceObject] annotation so that these types are now exposed to script: Coordinates -> GeolocationCoordinates Position -> GeolocationPosition PositionError -> GeolocationPositionError This is done in response to an effort to remove the [NoInterfaceObject] annotation from WebIDL. Spec pull requests (merged): https://github.com/w3c/geolocation-api/pull/20 https://github.com/w3c/geolocation-api/pull/23 Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/1471230
Also: Add [Exposed=Window] to these three interfaces: https://github.com/w3c/geolocation-api/pull/32
Created attachment 377067 [details] WIP Patch
Attachment 377067 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377069 [details] WIP Patch
Attachment 377069 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377070 [details] WIP Patch
Attachment 377070 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377072 [details] WIP Patch
Attachment 377072 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377076 [details] Patch
Created attachment 377077 [details] Patch
Attachment 377077 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 60 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377132 [details] Patch
Attachment 377132 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:73: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:78: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 5 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377135 [details] Patch
Attachment 377135 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:73: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:78: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 5 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377142 [details] Patch
Attachment 377142 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:73: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:78: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 5 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 377142 [details] Patch Clearing flags on attachment: 377142 Committed r249066: <https://trac.webkit.org/changeset/249066>
All reviewed patches have been landed. Closing bug.
<rdar://problem/54653181>